Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: add --hidden flag to cli add command #2649

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

PedroMiguelSS
Copy link
Contributor

@PedroMiguelSS PedroMiguelSS commented Dec 3, 2019

This PR adds --hidden flag to CLI's add command.

Closes #1917.

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alanshaw
Copy link
Member

alanshaw commented Dec 4, 2019

Can you fix up the tests please?

@PedroMiguelSS PedroMiguelSS force-pushed the feat/cli-hidden-flag-add-command branch 5 times, most recently from e4f5717 to 4683ba1 Compare December 6, 2019 12:09
Copy link
Member

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the console.log and skip the unrelated examples tests.

@achingbrain are you aware of whats going on with these tests ?

@PedroMiguelSS PedroMiguelSS force-pushed the feat/cli-hidden-flag-add-command branch from 4683ba1 to 449bb01 Compare December 6, 2019 15:50
@achingbrain
Copy link
Member

@hugomrdias the broken examples tests will be fixed by jkroso/parse-duration#11

@PedroMiguelSS
Copy link
Contributor Author

jkroso/parse-duration#11 fixed the problem. CI is fully green now 🎉

@achingbrain achingbrain merged commit ed886f4 into master Dec 10, 2019
@achingbrain achingbrain deleted the feat/cli-hidden-flag-add-command branch December 10, 2019 17:11
@alanshaw alanshaw mentioned this pull request Dec 11, 2019
57 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-evaluate hidden file handling still has interop with go-ipfs
4 participants